[cmake-developers] [CMake 0015738]: printw() should use format string

Mantis Bug Tracker mantis at public.kitware.com
Sat Sep 12 12:37:11 EDT 2015


The following issue has been SUBMITTED. 
====================================================================== 
http://public.kitware.com/Bug/view.php?id=15738 
====================================================================== 
Reported By:                Thomas Klausner
Assigned To:                
====================================================================== 
Project:                    CMake
Issue ID:                   15738
Category:                   CMake
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
====================================================================== 
Date Submitted:             2015-09-12 12:37 EDT
Last Modified:              2015-09-12 12:37 EDT
====================================================================== 
Summary:                    printw() should use format string
Description: 
Multiple files (in Source/CursesDialog/*.cxx) use the printw() function without
a format string, i.e.
printw(some_variable);
This is unsafe; if some_variable contains "%s" or similar, you have problems.

Please use the
printw("%s", some_variable);
idiom instead.


Steps to Reproduce: 
Code inspection.

Additional Information: 
The attached patch fixes this issue.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2015-09-12 12:37 Thomas KlausnerNew Issue                                    
2015-09-12 12:37 Thomas KlausnerFile Added: printw.diff                      
======================================================================



More information about the cmake-developers mailing list