[cmake-developers] [PATCH v3] FindHDF5.cmake HDF5_VERSION Support

Brad King brad.king at kitware.com
Wed May 13 10:04:38 EDT 2015


On 05/13/2015 08:20 AM, Brad King wrote:
> We could also consider moving the ".*" inside the match group
> and then reporting the result in HDF5_VERSION_STRING instead
> of HDF5_VERSION.

OTOH, HDF5 upstream distributes a CMake package configuration
file allowing one to set HDF5_DIR.  In this case find_package(HDF5)
will provide HDF5_VERSION, so we should be consistent with that.

I did have to update our topic for this after nightly testing
because Fedora packages H5pubconf.h under a different name.
I added a commit to check for a few name variants and then
rebased the version patch on that:

 FindHDF5: Check for a few H5pubconf*.h name variants
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4bd122ad

 FindHDF5: Add version support
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=56858178

-Brad



More information about the cmake-developers mailing list