[cmake-developers] [PATCH v3] FindHDF5.cmake HDF5_VERSION Support

Brad King brad.king at kitware.com
Wed May 13 08:20:27 EDT 2015


On 05/13/2015 02:58 AM, Huebl, Axel wrote:
> Thanks for merging and adding the test, that is great.

Thanks for working on the patch.

On 05/11/2015 07:32 AM, Huebl, Axel wrote:
> I would simply use
>
>   if( "${HDF5_VERSION_DEFINE}" MATCHES
>                 "H5_VERSION[ \t]+\"([0-9]+\\.[0-9]+\\.[0-9]+).*\"" )
>
> to match the group correctly.

We could also consider moving the ".*" inside the match group
and then reporting the result in HDF5_VERSION_STRING instead
of HDF5_VERSION.  Many other find modules do this.  The value
can still be used for version testing but the full version
string will be available for human reference.

-Brad



More information about the cmake-developers mailing list