[cmake-developers] FW: FW: Initial Attempt at Green Hill MULTI IDE Generator Support

[Geoffrey Viola]

>> I added some more commits to tweak a few things too:
>
>And a few more to fix our continuous testing results:
>
 >GHS: Do not use C++11 enum name scope
 >http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a4427fa9
>
 >GHS: Use !foo.empty() instead of foo.size() > 0
 >http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=54828b82
>
> GHS: Do not use string::back() that is missing on VS 7.1
> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dbc9f8c6

Thanks. That's good to know.

> Please do this based on commit dbc9f8c6 instead.

The attached patches should be based on that commit and then made sequentially.

>>> * Place "{" on its own line indented with the content inside the
Made the changes in patch 1. I used the attached clang format file.

>> > * Use "this->" on all member accesses inside methods.
Made the changes in patch 2.

> Also, several of the places that test for and add a trailing slash could be ported to use ConvertToUnixSlashes instead.  That always removes trailing slashes and would also fix any backslashes specified by project code in property values.

Made the changes in patch 3.

The total changes were tested: https://open.cdash.org/buildSummary.php?buildid=3743400. I'll test it on my internal projects.


Geoffrey Viola
SOFTWARE ENGINEER
asirobots.com

This message contains confidential information and is intended only for the recipient. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately if you have received this e-mail by mistake and delete this e-mail from your system. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-cleaned-up-trailing-slash-logic.patch
Type: application/octet-stream
Size: 2731 bytes
Desc: 0003-cleaned-up-trailing-slash-logic.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150325/9a0827cf/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-broke-lines-after-curly-brace-in-GHS-CPP-files.patch
Type: application/octet-stream
Size: 48768 bytes
Desc: 0001-broke-lines-after-curly-brace-in-GHS-CPP-files.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150325/9a0827cf/attachment-0005.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-added-this-to-member-accesses-in-GHS-CPP-files.patch
Type: application/octet-stream
Size: 27815 bytes
Desc: 0002-added-this-to-member-accesses-in-GHS-CPP-files.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150325/9a0827cf/attachment-0006.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: _clang-format
Type: application/octet-stream
Size: 340 bytes
Desc: _clang-format
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150325/9a0827cf/attachment-0007.obj>