[cmake-developers] FW: FW: Initial Attempt at Green Hill MULTI IDE Generator Support

Geoffrey Viola Geoffrey.Viola at asirobots.com
Tue Mar 24 09:14:35 EDT 2015


> The #include line needs to be moved similarly.  I made that fix and a few whitespace fixes.  I've attached a patch with those revisions.

Thanks.

> I noticed while making those fixes that you're using auto_ptr inside a map value.  The auto_ptr is documented as not suitable for use in containers in general.  For  TargetFolderBuildStreams you could just use a normal pointer and then cleanup in the generator destructor using cmDeleteAll.

Good catch. I made the switch. Attached is a new patch. Here's the test: https://open.cdash.org/buildSummary.php?buildid=3741919.


Geoffrey Viola
SOFTWARE ENGINEER
asirobots.com

This message contains confidential information and is intended only for the recipient. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately if you have received this e-mail by mistake and delete this e-mail from your system. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-some-support-for-a-Green-Hills-MULTI.patch
Type: application/octet-stream
Size: 62546 bytes
Desc: 0001-Added-some-support-for-a-Green-Hills-MULTI.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150324/94c80f8f/attachment-0001.obj>


More information about the cmake-developers mailing list