[cmake-developers] FW: FW: Initial Attempt at Green Hill MULTI IDE Generator Support

[Brad King]

On 03/16/2015 02:03 AM, Geoffrey Viola wrote:
> Done

Thanks for the updates.

I just noticed that in some of the new C++ sources you copied
the copyright block from other files but forgot to change the
notice lines to refer to yourself or your employer.  Certainly
the current lines do not refer to the author of the content ;)

> Added some documentation.

Good start.  Please adjust the section header underlines to
match the length of the title text.  Also, the new
variable/GHS-MULTI document needs to be added to the toctree
in 'Help/manual/cmake-variables.7.rst'.

This time I actually tried building the sources.  Some of
the classes prefix their inline method definitions:

 cmGlobalGhsMultiGenerator::GetGhsBuildCommand

This is not necessary when it is inside the class, and some
compilers do not like it.

Also the new lines you added to Source/cmake.cxx need to be
made conditional on the platform.  The CMakeLists.txt file
already contains the proper platform conditions, so use of
the new generator must match.

> I'm not quite sure why my FindModulesExecuteAll test fails.
> Seems like boost installation issue, but it isn't an issue
> in my nighlty test

Whether boost is found may depend on the environment, and your
nightly test wipes out PATH.

Thanks,
-Brad