[cmake-developers] Add command line options for deprecation message control

[Michael Scott]

Hi Brad,

Apologies for taking a little while with this. I've addressed those 
points and added all the tests I think are appropriate for this, however 
when I run one of them it fails because stderr is not as expected, but 
the actual and expected values are identical. Why would this happen?

Test I'm running:

/run_cmake_command(W_bad-arg1 ${CMAKE_COMMAND} -W)/

Output from running the test:

/  W_bad-arg1 - FAILED://
//
//  stderr does not match that expected.//
//
//  Command was://
//
//   command> "/home/mike/Documents/cmake/src/cmake/bin/cmake" "-W"//
//
//  Actual stdout://
//
//   actual-out> //
//
//  Expected stderr to match://
//
//   expect-err> CMake Error: -W must be followed with 
[no-][error=]<name>.//
//   expect-err> CMake Error: Problem processing arguments. Aborting.//
//
//  Actual stderr://
//
//   actual-err> CMake Error: -W must be followed with 
[no-][error=]<name>.//
//   actual-err> CMake Error: Problem processing arguments. Aborting./

Cheers,
Michael

On 15/06/2015 15:06, Brad King wrote:
> On 06/13/2015 01:41 PM, Michael Scott wrote:
>> I've implemented some changes to cmake.cxx and cmake.h, to implement
>> setting the CMAKE_ERROR_DEPRECATED and CMAKE_WARN_DEPRECATED variables
>> via command line options, for the Mantis issue 0014669, in a generic GCC
>> style pattern. I've attached the proposed patch to this email, does this
>> look like a sensible implementation?
> Thanks for working on this.  Here are some comments:
>
> * Please use 2 spaces and no tabs for indentation.
>
> * Please extend Tests/RunCMake/CommandLine to cover this or find
>    another appropriate test to update.  All options need coverage,
>    including the error cases.
>
> * The cmHasLiteralPrefix helper function may be useful in place
>    of "x.find(...) == 0".
>
> Thanks,
> -Brad
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150622/672770ee/attachment.html>