[cmake-developers] Add command line options for deprecation message control
Brad King
brad.king at kitware.com
Mon Jun 15 10:06:15 EDT 2015
On 06/13/2015 01:41 PM, Michael Scott wrote:
> I've implemented some changes to cmake.cxx and cmake.h, to implement
> setting the CMAKE_ERROR_DEPRECATED and CMAKE_WARN_DEPRECATED variables
> via command line options, for the Mantis issue 0014669, in a generic GCC
> style pattern. I've attached the proposed patch to this email, does this
> look like a sensible implementation?
Thanks for working on this. Here are some comments:
* Please use 2 spaces and no tabs for indentation.
* Please extend Tests/RunCMake/CommandLine to cover this or find
another appropriate test to update. All options need coverage,
including the error cases.
* The cmHasLiteralPrefix helper function may be useful in place
of "x.find(...) == 0".
Thanks,
-Brad
More information about the cmake-developers
mailing list