[cmake-developers] [PATCH] fixed msvc 64 bit build

[Stuermer, Michael SP/HZA-ZSEP]

> -----Original Message-----
> From: Brad King [mailto:brad.king at kitware.com]
> Sent: Monday, June 15, 2015 4:11 PM
> To: Stuermer, Michael SP/HZA-ZSEP
> Cc: cmake-developers at cmake.org
> Subject: Re: [cmake-developers] [PATCH] fixed msvc 64 bit build
> 
> On 06/15/2015 07:58 AM, Stuermer, Michael SP/HZA-ZSEP wrote:
> > This is just a one-char-bugfix, WIN32 instead of _WIN32 macro was
> used.
> 
> Thanks.  There are several instances of this in Source/*.  I've fixed
> the one you pointed out and more:
> 
>  Fix preprocessor checks WIN32 => _WIN32
>  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=83af11d4
> 
> There is one other in Source/kwsys that I've fixed in upstream KWSys:
> 
>  http://review.source.kitware.com/19926
> 
> and will integrate back to CMake after testing there.
> 
> > Are there any regular Win64 builds done actually?
> 
> Yes.  We have nightly testing for it which has been clean.
> It is also my main Windows development architecture.
> 
> The "WIN32" symbol is normally defined by CMAKE_CXX_FLAGS if the
> default flags are used for MSVC.  How did you configure the build?
> 
> -Brad

My setup was roughly:
 - Visual Studio 2013
 - CMake 3.0.2
 - Qt4.8.6
 - Qt dialog enabled
 - Documentation enabled
 - cpack with NSIS & WIX enabled
 - no special compiler configuration or so ...

I can not really reproduce if there was something broken in my CMake installation as I replaced it after successful build, but I didn't change any flags deliberately.

It doesn't really matter, but isn't the "WIN32" symbol defined in a common place for both 32 and 64 bit configurations? This makes it a bit interesting, as the 32 bit build worked flawlessly.

Michael