[cmake-developers] [PATCH] fixed msvc 64 bit build

[Brad King]

On 06/15/2015 07:58 AM, Stuermer, Michael SP/HZA-ZSEP wrote:
> This is just a one-char-bugfix, WIN32 instead of _WIN32 macro was used.

Thanks.  There are several instances of this in Source/*.  I've fixed the
one you pointed out and more:

 Fix preprocessor checks WIN32 => _WIN32
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=83af11d4

There is one other in Source/kwsys that I've fixed in upstream KWSys:

 http://review.source.kitware.com/19926

and will integrate back to CMake after testing there.

> Are there any regular Win64 builds done actually?

Yes.  We have nightly testing for it which has been clean.
It is also my main Windows development architecture.

The "WIN32" symbol is normally defined by CMAKE_CXX_FLAGS if the
default flags are used for MSVC.  How did you configure the build?

-Brad