[cmake-developers] Setting additional compile flags to .hlsl files?

Robert Goulet Robert.Goulet at autodesk.com
Tue Jan 27 12:47:37 EST 2015


There you go. Let me know if it's good now.

-----Original Message-----
From: Brad King [mailto:brad.king at kitware.com] 
Sent: Monday, January 26, 2015 3:09 PM
To: Robert Goulet
Cc: cmake-developers at cmake.org
Subject: Re: [cmake-developers] Setting additional compile flags to .hlsl files?

On 01/26/2015 02:28 PM, Robert Goulet wrote:
> Here's a patch for adding additional compile flags to .hlsl files in 
> Visual Studio. For this I simply added the new VS_SHADER_FLAGS source 
> file property and basically did the same as other VS_SHADER_* 
> properties.

Okay.  Please use spaces instead of tabs and match the surrounding indentation.  Also please add/modify:

 Help/prop_sf/VS_SHADER_FLAGS.rst
 Help/manual/cmake-properties.7.rst

to add the documentation, and add a release note as:

 Help/release/dev/vs-shader-flags.rst

following the style of other release note files in that directory.

Also please extend Tests/VSWinStorePhone/CMakeLists.txt with a test for this feature.

Thanks,
-Brad

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vs-shader-flags.patch
Type: application/octet-stream
Size: 5959 bytes
Desc: vs-shader-flags.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150127/3273805d/attachment.obj>


More information about the cmake-developers mailing list