[cmake-developers] Questions about code reviews and static analysis tools for TU Delft research

[Brad King]

On 02/24/2015 05:53 AM, Radjino Bholanath wrote:
> 1. Do all developers (contributors and core developers)
>    have to submit a code review for every change?

Every change is reviewed before it is merged to the 'master' branch
for official inclusion.

The process for new contributors is documented here:

 http://www.cmake.org/gitweb?p=cmake.git;a=blob_plain;f=CONTRIBUTING.rst;hb=master

The process for authorized developers is documented here:

 http://www.cmake.org/Wiki/CMake/Git/Develop

Contributors send patches to this mailing list and may go through
a few iterations of review with an authorized developer before
being integrated.  Authorized developers then take such patches
(or their own changes) and merge them to a 'next' branch on which
extensive nightly tests are run.  When testing is clean then the
maintainer performs a final review before accepting changes and
merging them to 'master'.

> 2. Which code review tools are used?

Email.  No formal review tools are used currently.

> 3. Are static analyzers used? If they are used:
>   a. Is passing the checks of the static analyzers necessary
>      for a change to be accepted?

This is part of the nightly testing.

>   b. Which static analyzers are used?

Clang scan-build.

We also use dynamic analysis with valgrind and Clang AddressSanitizer.

-Brad