[cmake-developers] [REVIEW REQUEST] find_package(Protobuf CONFIG)

[Konstantin Podsvirov]

Hi, Brad!

03.08.2015, 23:26, "Brad King" <brad.king at kitware.com>:
> On 08/02/2015 03:31 PM, Konstantin Podsvirov wrote:
>> https://github.com/google/protobuf/pull/673
>
> [snip]
>> I try to make find_package(Protobuf [MODULE|CONFIG]) compatible.
>
> Thanks for working on this. Thanks for the FindProtobuf module
> compatibility layer. I tried your changes locally as of commit
> 5500b069 on Linux and Windows. The basic build and install works
> and I'm able to "find_package(Protobuf CONFIG)" from a test project.

Great! I myself have not tried Linux. Now the header files
only installs on Windows. Of course I am interested in the solution
this question and think in the near future I'll figure it out.

> The structure of the produced files looks correct at a glance.

Learning without practice is not effective, practice without training - destructive :-)

> The protobuf-config-version.cmake should be taught to actually
> check the version number to see if it is compatible with that
> requested. Doing so requires understanding of protbuf's
> version scheme and compatibility requirements.

Yes, I know about it. But decided to postpone until better times.

> -Brad

Brad thank you for taking the time and effort.

We hope our efforts will be useful and appreciated by other developers.

--
Regards,
Konstantin Podsvirov