[cmake-developers] FW: FW: Initial Attempt at Green Hill MULTI IDE Generator Support

Geoffrey Viola Geoffrey.Viola at asirobots.com
Thu Apr 9 08:56:46 EDT 2015


> I get conflicts applying on commit ff7ecb92.  Please resolve.

I rebased on ff7ecb92 to create the new attached patch. Here are the test results: https://open.cdash.org/buildSummary.php?buildid=3763362.

>> target_compile_options(${TARGET_NAME} PUBLIC
>>     ":optionsFile=\"${ABS_PATH}/rel/path/filename\"")
>
>The COMPILE_OPTIONS are supposed to be given flags exactly as you'd like the tools to receive them, and CMake is supposed to take care of the quoting.  This is different than the older COMPILE_FLAGS value that is just a command line string.
>
>Therefore I think you should be writing:
>
> target_compile_options(${TARGET_NAME} PUBLIC
>     ":optionsFile=${ABS_PATH}/rel/path/filename")
>
>which is expected to work even if there is a space in the ABS_PATH value.

That seems to be working, but I need to do more testing.

Now that the flags seem to be working correctly, I'll need to remove the hard coded "--link_once_templates" flag.


Geoffrey Viola
SOFTWARE ENGINEER
asirobots.com



-----Original Message-----
From: Brad King [mailto:brad.king at kitware.com]
Sent: Wednesday, April 08, 2015 7:22 AM
To: Geoffrey Viola
Cc: cmake-developers at cmake.org
Subject: Re: FW: FW: [cmake-developers] Initial Attempt at Green Hill MULTI IDE Generator Support

On 04/08/2015 01:20 AM, Geoffrey Viola wrote:
> Attached is a patch based off of the previous commit.

I get conflicts applying on commit ff7ecb92.  Please resolve.

> target_compile_options(${TARGET_NAME} PUBLIC
>     ":optionsFile=\"${ABS_PATH}/rel/path/filename\"")

The COMPILE_OPTIONS are supposed to be given flags exactly as you'd like the tools to receive them, and CMake is supposed to take care of the quoting.  This is different than the older COMPILE_FLAGS value that is just a command line string.

Therefore I think you should be writing:

 target_compile_options(${TARGET_NAME} PUBLIC
     ":optionsFile=${ABS_PATH}/rel/path/filename")

which is expected to work even if there is a space in the ABS_PATH value.

-Brad

This message contains confidential information and is intended only for the recipient. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately if you have received this e-mail by mistake and delete this e-mail from your system. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ghs-gen-uses-cmake-vars-for-flags.patch
Type: application/octet-stream
Size: 30164 bytes
Desc: 0001-ghs-gen-uses-cmake-vars-for-flags.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150409/b576e62e/attachment-0001.obj>


More information about the cmake-developers mailing list