[cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

Bach, Pascal pascal.bach at siemens.com
Thu Sep 4 06:42:56 EDT 2014


 
> > +  else if (this->SystemName == "WindowsCE")
> > +    {
> > +    this->SystemIsWindowsCE = true;
> > +    if (!this->InitializeWindowsCE(mf))
> 
> At the beginning of this block you should check/reject when
> the generator name specified a platform name.  Something like:
> 
>     if(this->PlatformName != "Win32")
>       {
>       cmOStringStream e;
>       e << "CMAKE_SYSTEM_NAME is 'WindowsCE' but CMAKE_GENERATOR "
>         << "specifies a platform too: '" << this->GetName() << "'";
>       mf->IssueMessage(cmake::FATAL_ERROR, e.str());
>       return false;
>       }
> 

This won't' work as the code gets called multiple times during a project generation, but only the first time it is set to Win32. So the code will fail the second time.
I need to put the code somewhere earlier in the initialization but don't know yet where.

I will submit an updated version soon.

Pascal



More information about the cmake-developers mailing list