[cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

[Brad King]

On 09/03/2014 01:21 PM, Bach, Pascal wrote:
> This is only a first draft and I would like to hear if I am on the right track.

Yes, it looks good so far.

> +  else if (this->SystemName == "WindowsCE")
> +    {
> +    this->SystemIsWindowsCE = true;
> +    if (!this->InitializeWindowsCE(mf))

At the beginning of this block you should check/reject when
the generator name specified a platform name.  Something like:

    if(this->PlatformName != "Win32")
      {
      cmOStringStream e;
      e << "CMAKE_SYSTEM_NAME is 'WindowsCE' but CMAKE_GENERATOR "
        << "specifies a platform too: '" << this->GetName() << "'";
      mf->IssueMessage(cmake::FATAL_ERROR, e.str());
      return false;
      }

Thanks,
-Brad