[cmake-developers] [PATCH] Preinstall requirements support for CPack RPM generator

[Evgeny Kalishenko]

Little correction: the first comment "CPackRPM: Support pre(post) install
scripts" differs from mine "Requires for pre(post) install scripts are
implemented" and can cause misunderstanding. Because "pre(post) install
scripts" are already implemented.

2014-10-27 17:55 GMT+03:00 Brad King <brad.king at kitware.com>:

> On 10/27/2014 10:41 AM, Rolf Eike Beer wrote:
> >> if("${_RPM_SPEC_HEADER}" MATCHES "REQUIRES_PRE"  OR
> >> "${_RPM_SPEC_HEADER}" MATCHES "REQUIRES_POST")
> >
> > This should really be using STREQUAL and not using dereferences on the
> > left hand side.
>
> Thanks.  Actually I mentioned that in my first review in this thread
> but forgot to check that it had been resolved in updated patches.
>
> It doesn't matter though because the second commit replaces that
> line with different logic anyway.
>
> -Brad
>
>


-- 
Regards,
Evgeny Kalishenko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141027/29011af5/attachment.html>