[cmake-developers] [PATCH] Preinstall requirements support for CPack RPM generator

Brad King brad.king at kitware.com
Mon Oct 27 10:55:50 EDT 2014


On 10/27/2014 10:41 AM, Rolf Eike Beer wrote:
>> if("${_RPM_SPEC_HEADER}" MATCHES "REQUIRES_PRE"  OR  
>> "${_RPM_SPEC_HEADER}" MATCHES "REQUIRES_POST")
> 
> This should really be using STREQUAL and not using dereferences on the 
> left hand side.

Thanks.  Actually I mentioned that in my first review in this thread
but forgot to check that it had been resolved in updated patches.

It doesn't matter though because the second commit replaces that
line with different logic anyway.

-Brad



More information about the cmake-developers mailing list