[cmake-developers] [Review request] Topic FindPkgConfig_Extend-PKG_CONFIG_PATH

Brad King brad.king at kitware.com
Thu Mar 6 13:51:21 EST 2014


On 03/06/2014 01:22 PM, Daniele E. Domenichelli wrote:
> On 06/03/14 17:25, Brad King wrote:
>> revise the documentation formatting first
> 
> Done.

Thanks.  Here are a couple comments:

> +.. command:: pkg_check_modules
> +
> +Checks for all the given modules.

The text defining the command needs to be indented to be part of
the explicit markup block.

> +.. code-block:: cmake
> +
> +   pkg_check_modules(<PREFIX> [REQUIRED] [QUIET] <MODULE> [<MODULE>]*)

The documentation style guide:

  http://www.cmake.org/cmake/help/v3.0/manual/cmake-developer.7.html#style

says that command signatures should be plain literal blocks
and not "cmake" code-blocks.

Similar fixes will be needed throughout the module.

Thanks,
-Brad




More information about the cmake-developers mailing list