[cmake-developers] [Review request] Topic FindPkgConfig_Extend-PKG_CONFIG_PATH

Brad King brad.king at kitware.com
Wed Mar 5 11:36:54 EST 2014


On 03/04/2014 10:07 PM, Daniele E. Domenichelli wrote:
> Follow up to this thread:
>   http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8369
> 
> Please review the topic FindPkgConfig_Extend-PKG_CONFIG_PATH.

Nice!  Please revise the documentation to use proper cross-reference
syntax to link to other variables instead of just inline literals:

 ``SOME_VARIABLE`` => :variable:`SOME_VARIABLE`

Also it looks like some logic is taken from GNUInstallDirs.  Is there
enough in common to try to factor that out into a helper module?

Thanks,
-Brad




More information about the cmake-developers mailing list