[cmake-developers] Modules/FindLua51.cmake: lua5.1 include path seems wrong

[Rolf Eike Beer]

Am Montag, 9. Juni 2014, 10:00:35 schrieben Sie:
> On 06/08/2014 09:12 AM, o.kurz at gmx.de wrote:
> > I deleted the additional "include/" in FindLua51.cmake and it worked.
> 
> I think that is the correct fix.  I do not know why they were there
> in the first place.  They appear in FindLua50, FindLua51, and the
> version-agnostic FindLua module.  Eike, did you just preserve that
> idiom when creating the latter module or did you discover the reason
> the include/ is needed in PATH_SUFFIXES?

I just kept it, I refuse to have any knowledge about Lua ;)

> Also I would appreciate a generalized path that covers all the
> modules.  Explain in the commit message why the behavior of the
> find_path command's PATH_SUFFIXES option makes the include/
> portion of the path unnecessary.  (Actually I think the trailing
> "include" can be dropped too).

The cleanup to use FindLua in FindLua5[01] is also still missing. If someone 
with actual Lua experience could do this this would be greatly welcomed.

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140609/45cb775a/attachment-0002.sig>