[cmake-developers] Review request: use PKG_CONFIG

[Christoph Grüninger]

Hi Brad,
there is a statement in the commit message:
  "FPHSA now checks for PKG_CONFIG_VERSION_STRING to ensure
  that the executable given by PKG_CONFIG is an executable
  and has a --version parameter."

While testing, I set PKG_CONFIG to a random path like
/usr/bin/kate. This was accepted by FindPkgConfig.
Requiring PKG_CONFIG_VERSION_STRING ensures, that at
least the --version thing is supported. This makes it
more likely that a pkg-config executable is found.

Is my idea wrong or just my explanation not precise enough?

Bye
Christoph

> Brad King <brad.king at kitware.com> hat am 25. Februar 2014 um 14:35 geschrieben:
>
>
> On 02/24/2014 06:14 PM, Christoph Grüninger wrote:
> > overhauled version at
> > https://github.com/gruenich/CMake/commit/75f5f2a8df590c560455ce8310f3d9fe76af01b1
>
> Thanks.  Can you explain the purpose of the hunk adding
> PKG_CONFIG_VERSION_STRING:
>
> - REQUIRED_VARS PKG_CONFIG_EXECUTABLE
> + REQUIRED_VARS PKG_CONFIG_EXECUTABLE PKG_CONFIG_VERSION_STRING
>
> ?
>
> It seems unrelated to the other parts of the change.
>
> Thanks,
> -Brad