[cmake-developers] visual-studio-preprocessor-undefine fix for /U problems

[Steve Wilson]

Interesting, I’ll revisit it.

On Feb 17, 2014, at 8:43 AM, Brad King <brad.king at kitware.com> wrote:

> On 02/14/2014 04:24 PM, Steve Wilson wrote:
>> new method OutputDefinitionsByTag and adds an argument that lets you specify the tag.    I also fixed the test case.
> 
> Thanks.  I don't see in the new changes where it actually uses the
> parsed Undefines member.  It looks like it just adds the main
> definitions with both UndefinePreprocessorDefintions and
> PreprocessorDefintions.  Shouldn't OutputDefinitionsByTag take
> an argument telling it what list of definitions to use, and then
> used as an implementation detail of OutputPreprocessorDefinitions
> and OutputUndefinePreprocessorDefinitions?
> 
> -Brad
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140217/5995b87a/attachment-0002.sig>