[cmake-developers] [New Module] FindOpenCL, FindHg

[Stephen Kelly]

Rolf Eike Beer wrote:

> Am Sonntag, 16. Februar 2014, 18:43:01 schrieb Matthäus G. Chajdas:
>> Hi Eike,
>> 
>> thanks for reviewing! I've just pushed a new version, which should fix
>> all the issues you mentioned. I'm also setting now Hg_FOUND using
>> FOUND_VAR (this is also recommended in the documentation.)
>> 
>> Anything more left to do? The only thing which bothers me is the
>> _VERSION_STRING in FindHg (which is similar to FindGit) and the same
>> variable being called _VERSION in OpenCL, if there is a policy on that,
>> I would like to use the same variable name in both. Right now I was
>> aiming more for consistency with existing packages.
> 
> There has been a Modules/readme.txt, no idea where it is now in rst. But
> the preferred nameing ins Hg_VERSION_STRING and OpenCL_VERSION_STRING.

If the readme file says that, then the readme file is wrong. The canonical 
way to name it is *_VERSION, not *_VERSION_STRING, as that is how config-
file packages work.

If the readme file says that, then it should be changed, just like a 
recommendation was changed in commit 140692d84c.

Thanks,

Steve.