[cmake-developers] visual-studio-preprocessor-undefine fix for /U problems

[Steve Wilson]

Will do.

On Feb 14, 2014, at 11:26 AM, Brad King <brad.king at kitware.com> wrote:

> On 2/13/2014 7:33 PM, Steve Wilson wrote:
>> The topic is visual-studio-preprocessor-undefine.
> 
> Thanks.  The method
> 
> cmVisualStudioGeneratorOptions
> ::OutputUndefinePreprocessorDefinitions
> 
> appears to duplicate a lot of code from
> 
> cmVisualStudioGeneratorOptions
> ::OutputPreprocessorDefinitions
> 
> Please factor out and parameterize the common pieces to
> avoid the duplication.
> 
> Also, the test case appears to undef a macro in a specific
> source file and test that it is undefined, but never defines
> the macro for the whole target so of course it will never
> be defined and the test will always pass.
> 
> Thanks,
> -Brad
> -- 
> 
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
> 
> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140214/4458e14a/attachment-0002.sig>