[cmake-developers] visual-studio-preprocessor-undefine fix for /U problems

Brad King brad.king at kitware.com
Fri Feb 14 13:26:22 EST 2014


On 2/13/2014 7:33 PM, Steve Wilson wrote:
> The topic is visual-studio-preprocessor-undefine.

Thanks.  The method

 cmVisualStudioGeneratorOptions
 ::OutputUndefinePreprocessorDefinitions

appears to duplicate a lot of code from

 cmVisualStudioGeneratorOptions
 ::OutputPreprocessorDefinitions

Please factor out and parameterize the common pieces to
avoid the duplication.

Also, the test case appears to undef a macro in a specific
source file and test that it is undefined, but never defines
the macro for the whole target so of course it will never
be defined and the test will always pass.

Thanks,
-Brad



More information about the cmake-developers mailing list