[cmake-developers] AddCustomCommandWithConfig

[Stephen Kelly]

Steve Wilson wrote:

> I just pushed the topic AddCustomCommandWithConfig to stage.   This topic
> implements the CONFIG keyword for add_custom_command().

I haven't looked thoroughly, but how much does dependency 
specification/handling need to change? The dependency of a command on a set 
of targets should now be config-specific, right? Does that mean making 
changes to cmTargetTraceDependencies::CheckCustomCommand? What other impact 
is there on dependency handling here?

Does the first patch in your topic pass the unit tests it adds? Is the 
second patch needed for that? If so, they belong in one patch, so squash 
them together. The documentation should be added in the patch that adds the 
feature, not in a separate patch.

Thanks,

Steve.