[cmake-developers] [PATCH] Automoc documentation is misleading

Alex Merry kde at randomguy3.me.uk
Tue Feb 4 09:44:33 EST 2014


On 04/02/14 12:45, Stephen Kelly wrote:
> Alex Merry wrote:
> 
>> If you have a header file like foo.h and the corresponding source file
>> is, say, foo_win.cpp, automoc will never look at foo.h.
> 
> ... unless you include moc_foo.cpp in foo_win.cpp, right?

Yes; the fix is easy, but developers need to be aware that it is necessary.

>> The attached patch makes the documentation clear on this point.
> 
> Please create patches with `git format-patch`. It preserves authorship 
> information.

I did, and then removed the mail headers.  I'll leave them there in future.

> I don't think there is a need to change the cmake-qt manual. I've pushed the 
> rest to next for testing.

OK.  The wording did end up getting quite complicated in the cmake-qt
manual.  It might be worth having something like "see the documentation
for that property for exactly which files are scanned".

Alex




More information about the cmake-developers mailing list