[cmake-developers] Patch pull request: support for shader entry point and shader model for Visual Studio FXCompiler custom tool build

[Cedric Perthuis]

Minor feedback, this comment should say "which shader model to use" instead
of "which entry point to use"

+    // Figure out which entry point to use if any
+    if (const char* sm = sf->GetProperty("VS_SHADER_MODEL"))



On Wed, Dec 3, 2014 at 11:08 AM, Cedric Perthuis <cedric.perthuis at gmail.com>
wrote:

> That sounds great, thanks Brad!
>
> On Wed, Dec 3, 2014 at 7:12 AM, Brad King <brad.king at kitware.com> wrote:
>
>> On 12/02/2014 10:27 AM, Brad King wrote:
>> >  VS: Add source file properties to set the hlsl shader entry point and
>> model
>> >  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5ab06dcd
>>
>> I updated the patch to sort the cmake-properties manual list in order:
>>
>>  VS: Add source file properties to set the hlsl shader entry point and
>> model
>>  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2a224b4c
>>
>> I've queued this for inclusion in the next 3.1 release candidate because
>> otherwise the new hlsl feature it not very useful.
>>
>> Thanks,
>> -Brad
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141203/fc4e3a27/attachment.html>