[cmake-developers] [Review request] FindwxWidgets: Improve path detection logic when cross-compiling.

Brad King brad.king at kitware.com
Fri Aug 22 13:27:07 EDT 2014


On 08/22/2014 01:23 PM, Richard Shaw wrote:
>> Please use empty else() and endif().  Otherwise, looks good.
> 
> Fixed:
[snip]
>  #=====================================================================
> +# Determine whether unix or win32 paths should be used
>  #=====================================================================
> -if(WIN32 AND NOT CYGWIN AND NOT MSYS)
> +if(WIN32 AND NOT CYGWIN AND NOT MSYS AND NOT CMAKE_CROSSCOMPILING)
>    set(wxWidgets_FIND_STYLE "win32")
>  else()
> -  if(UNIX OR MSYS)
> -    set(wxWidgets_FIND_STYLE "unix")
> -  endif()
> +  set(wxWidgets_FIND_STYLE "unix")
>  endif()

Good, thanks.  Please merge for testing.

-Brad




More information about the cmake-developers mailing list