[cmake-developers] [Review request] FindwxWidgets: Improve path detection logic when cross-compiling.

[Richard Shaw]

On Fri, Aug 22, 2014 at 12:08 PM, Brad King <brad.king at kitware.com> wrote:

> On 08/22/2014 12:39 PM, Richard Shaw wrote:
> > Simple logic update to check if we're cross-compiling to determine if
> unix or win32 path find style should be used.
> >
> > FindwxWidgets: Improve path detection logic when cross-compiling.
> [snip]
> > +else(WIN32 AND NOT CYGWIN AND NOT MSYS AND NOT CMAKE_CROSSCOMPILING)
> > +  set(wxWidgets_FIND_STYLE "unix")
> > +endif(WIN32 AND NOT CYGWIN AND NOT MSYS AND NOT CMAKE_CROSSCOMPILING)
>
> Please use empty else() and endif().  Otherwise, looks good.
>
> Fixed:

http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=33286235048495ceafb636d549d9a4e8891967ae

Thanks,
Richard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140822/e67c64af/attachment-0002.html>