[cmake-developers] [Review Request] Topic wxWidgets-cflags

[Richard Shaw]

On Thu, Aug 21, 2014 at 2:21 PM, Brad King <brad.king at kitware.com> wrote:

> On 08/21/2014 02:30 PM, Richard Shaw wrote:
> >    if   (wxWidgets_CXX_FLAGS)
> > +    # Flags are expected to be a string here, not a list.
> > +    string(REPLACE ";" " " wxWidgets_CXX_FLAGS "${wxWidgets_CXX_FLAGS}")
> >      set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${wxWidgets_CXX_FLAGS}")
>
> Thanks.  However, we shouldn't leak our local modification to the value
> of wxWidgets_CXX_FLAGS, so the substitution should be done with the
> result stored in a temporary local variable.
>

So the string command should be something like:

string(REPLACE ";" " " wxWidgets_CXX_FLAGS_str "${wxWidgets_CXX_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${wxWidgets_CXX_FLAGS_str}")


Also, please start the commit message in "UsewxWidgets: ...".
>

Ahh, I see how that would be helpful!

Thanks,
Richard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140821/5a16ffca/attachment-0002.html>