[cmake-developers] [Review Request] Topic wxWidgets-cflags

[Brad King]

On 08/21/2014 02:30 PM, Richard Shaw wrote:
>    if   (wxWidgets_CXX_FLAGS)
> +    # Flags are expected to be a string here, not a list.
> +    string(REPLACE ";" " " wxWidgets_CXX_FLAGS "${wxWidgets_CXX_FLAGS}")
>      set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${wxWidgets_CXX_FLAGS}")

Thanks.  However, we shouldn't leak our local modification to the value
of wxWidgets_CXX_FLAGS, so the substitution should be done with the
result stored in a temporary local variable.

Also, please start the commit message in "UsewxWidgets: ...".

Thanks,
-Brad