[cmake-developers] [PATCH] New module: FindIce.cmake

[Rolf Eike Beer]

Roger Leigh wrote:
> On Sun, Aug 17, 2014 at 05:22:38PM +0100, Roger Leigh wrote:
> > On Sun, Aug 17, 2014 at 05:50:58PM +0200, Rolf Eike Beer wrote:
> > > Am Sonntag, 17. August 2014, 16:21:24 schrieb Roger Leigh:
> > > > On Fri, Aug 15, 2014 at 12:31:17AM +0100, Roger Leigh wrote:
> > > > > OK.  I'll have to read up on this and see what needs doing.
> > > > > In the meantime, I've attached a revised patch with all the
> > > > > above corrections included.
> > > > 
> > > > Based on the comments made on my other FindXerces patch, I've
> > > > updated this patch to also use current naming and usage
> > > > conventions.  I hope this is all OK with you.
> > > 
> > > +    if((MSVC_VERSION EQUAL 1400) OR (MSVC_VERSION GREATER 1400 AND
> > > MSVC_VERSION LESS 1500)) if((NOT MSVC_VERSION VERSION_LESS 1400 AND
> > > MSVC_VERSION LESS 1500)> 
> > Thanks, I've fixed this now in the attached patch.
> 
> One single line change to the patch attached, to add support for
> FreeBSD, which uses a different slice directory (unversioned
> share/Ice).

Pushed, including some cleanups:
-remove text in else(), endif() and so on (applies also to FindXerces)
-if (...) else() can be if (NOT ...)
-used elseif for MSVC version scanning, once you have found one version the 
other if's can't be true

Please check if I have messed something up.

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140821/5edbb4d2/attachment-0002.sig>