[cmake-developers] [PATCH] New module: FindIce.cmake

[Roger Leigh]

On Sun, Aug 17, 2014 at 05:22:38PM +0100, Roger Leigh wrote:
> On Sun, Aug 17, 2014 at 05:50:58PM +0200, Rolf Eike Beer wrote:
> > Am Sonntag, 17. August 2014, 16:21:24 schrieb Roger Leigh:
> > > On Fri, Aug 15, 2014 at 12:31:17AM +0100, Roger Leigh wrote:
> > > > OK.  I'll have to read up on this and see what needs doing.
> > > > In the meantime, I've attached a revised patch with all the
> > > > above corrections included.
> > > 
> > > Based on the comments made on my other FindXerces patch, I've
> > > updated this patch to also use current naming and usage
> > > conventions.  I hope this is all OK with you.
> > 
> > +    if((MSVC_VERSION EQUAL 1400) OR (MSVC_VERSION GREATER 1400 AND MSVC_VERSION LESS 1500))
> > if((NOT MSVC_VERSION VERSION_LESS 1400 AND MSVC_VERSION LESS 1500)
> 
> Thanks, I've fixed this now in the attached patch.

One single line change to the patch attached, to add support for
FreeBSD, which uses a different slice directory (unversioned
share/Ice).

This has now been tested on:
- Windows with all Ice 3.3, 3.4 and 3.5 versions with
  VS 2010, 2012, 2013
- MacOS 10.8 and 10.9 with homebrew ice
- Linux with Ubuntu 2012.04/ice34, 2014.04/ice35,
             Debian unstable/ice35 and
             CentOS 6.5/ice34.
- FreeBSD 10.0-STABLE with devel/ice (3.5.1) port


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-FindIce-New-module-to-find-ZeroC-Ice.patch
Type: text/x-diff
Size: 18700 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140818/f9b22a9d/attachment-0002.patch>