[cmake-developers] [PATCH] New module FindXerces

[Rolf Eike Beer]

Roger Leigh wrote:
> Dear Chuck,
> 
> Thanks for looking at this.  Please find attached a new copy of the
> patch which should address all your points.  If you would like any
> further changes making, please just let me know.

I don't think you need the functions for anything, especially not 
_Xerces_FIND. From what I can tell they only serve the purpose of not leaking 
variables. The only thin protected in _Xerces_FIND are the version components, 
that could easily be fixed by just returning the concatenated version string 
from the inner function. What I would find more useful is actually checking 
that Xerces_INCLUDE_DIR is set before calling _Xerces_GET_VERSION(), otherwise 
you would try to open "/xercesc/util/XercesVersion.hpp", which is definitely 
wrong.

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140817/3cc7f9b3/attachment-0002.sig>