[cmake-developers] [PATCH] New module FindXerces

Roger Leigh rleigh at codelibre.net
Sun Aug 17 08:01:19 EDT 2014


Dear Chuck,

Thanks for looking at this.  Please find attached a new copy of the
patch which should address all your points.  If you would like any
further changes making, please just let me know.

Regards,
Roger

On Sat, Aug 16, 2014 at 11:11:42AM -0400, Chuck Atkins wrote:
> Hey Roger, thanks for the contribution!  A couple of points on find_module
> convention, most of which you can find in
> http://cmake.org/cmake/help/v3.0/manual/cmake-developer.7.html#modules.
> Not all find modules currently shipped have been updated for these best
> practices but new modules should try to stick to them.
> 
>    - Xerces_INCLUDE_DIR should be used to control the cache search but not
>    as a final output variable.  Use Xerces_INCLUDE_DIRS.  This helps with some
>    consistency since some libs may have only 1 include directory and others
>    have several.  This way all find modules produce a Foo_INCLUDE_DIRS
>    variable instead of some producing _DIR and others producing _DIRS
>    - Xerces_LIBRARY_DIR is not actually used and should be removed from
>    documentation.
>    - Use Xerces_INCLUDE_DIR and Xerces_LIBRARY as the find_path and
>    find_library variables.  After successfully passing the
>    FIND_PACKAGE_HANDLE_STANDARD_ARGS, then set the _INCLUDE_DIRS and
>    _LIBRARIES variables accordingly.
>    - Try to stick with either all mixed-case or all uppercase variable
>    names.  No need to mix Xerces_FOO with XERCES_FOO.  In this case, keeping
>    with all mixed case would be appropriate.
>    - Don't delete the version variable afterwards, it's good have set by
>    the find module as an output variable Xerces_VERSION.
> 
> 
> - Chuck
> 
> 
> On Sat, Aug 16, 2014 at 6:48 AM, Roger Leigh <rleigh at codelibre.net> wrote:
> 
> > Hi,
> >
> > Attached is a patch to add support for Apache Xerces-C++.
> > This project is quite an old one, and doesn't have any
> > support for cmake at present.  This will allow cmake
> > projects to use current and older Xerces releases.
> >
> >
> > Regards,
> > Roger
> >
> > --
> >   .''`.  Roger Leigh
> >  : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
> >  `. `'   schroot and sbuild
> > http://alioth.debian.org/projects/buildd-tools
> >    `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083
> > E800
> >
> > --
> >
> > Powered by www.kitware.com
> >
> > Please keep messages on-topic and check the CMake FAQ at:
> > http://www.cmake.org/Wiki/CMake_FAQ
> >
> > Kitware offers various services to support the CMake community. For more
> > information on each offering, please visit:
> >
> > CMake Support: http://cmake.org/cmake/help/support.html
> > CMake Consulting: http://cmake.org/cmake/help/consulting.html
> > CMake Training Courses: http://cmake.org/cmake/help/training.html
> >
> > Visit other Kitware open-source projects at
> > http://www.kitware.com/opensource/opensource.html
> >
> > Follow this link to subscribe/unsubscribe:
> > http://public.kitware.com/mailman/listinfo/cmake-developers
> >

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-FindXerces-New-module-to-find-Apache-Xerces-C.patch
Type: text/x-diff
Size: 5658 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140817/fc5a4cc7/attachment-0002.patch>


More information about the cmake-developers mailing list