[cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

[Nils Gladitz]

Hello Bill, thanks for looking into this!

All four tests in my example are still run (as you can see in the test 
output I provided).
This includes the dependent test.

What I did change is that all tests (from an dependency or otherwise) 
are run from StartNextTests() which ensures that serial tests run alone 
rather than from StartTest() which did not seem to account for this.

Nils


On 17.10.2013 23:19, Bill Hoffman wrote:
> On 10/17/2013 4:41 PM, Nils Gladitz wrote:
>>
>> I pushed my topic "ctest-fix-run-serial" to stage.
> I am taking a look.   It has been a long time since I looked at this 
> code.  However, it seems like your patch removes the running of 
> dependent tests.
>
> old code did this:
> StartTest(int test)
>  ...
>  foreach d in depend tests of test
>     startTests
>
>
> New code removes that.   I guess it depends on SortedTests having 
> taken depends into consideration, which I am not seeing.  However, I 
> might be missing something....
>
> What was your thinking on this?
>
> -Bill
>
> -- 
>
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at 
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at: 
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers