[cmake-developers] Perforce patch for CTest

[Rolf Eike Beer]

Am Mittwoch, 2. Oktober 2013, 13:10:20 schrieb Pedro Navarro:
> > >    - It requires an English version of Perforce (use the P4_OPTIONS
> > >    variable, documented below to pass the -L switch to change the
> > >    message
> > >    language if you installation has a different one). It shouldn't be
> > >    too
> > > 
> > > hard to change the regular expressions used for parsing to not key on a
> > > specific word but on character ranges. I'll look into that if this
> > 
> > becomes
> > 
> > > an issue.
> > 
> > Maybe set P4_OPTIONS automatically to -Lenglish (or whatever) in case it
> > is
> > not set?
> 
> I tried that originally but had no effect. Also, on the perforce
> documentation it says that "Specifies the language to use for error
> messages from the Perforce service. In order for this flag to work, your
> administrator must have loaded support for non-English messages in the
> database", so I didn't feel comfortable adding a flag globably without
> knowing it might even trigger an error (like invalid language or something
> like that).
> 
> Perforce offers the P4LANGUAGE environment variable which can be used to
> configure the client for updates, and we also have the P4_OPTIONS variable,
> so I think for now it's a good solution/workaround until we have more
> information.

Can you set P4LANGUANGE unconditionally then? Like it is done in 
FindSubversion.cmake to get proper output.

And of course this needs testcases, and a host that has Perforce installed and 
drives those tests. ;)

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20131002/5182466f/attachment.sig>