[cmake-developers] ExportImport test failures
Stephen Kelly
steveire at gmail.com
Sat May 18 04:07:54 EDT 2013
Brad King wrote:
> On 05/17/2013 11:43 AM, Stephen Kelly wrote:
>> Yesterday in the continuous dashboards, several windows machines started
>> failing with this test in a way that does not make sense:
>>
>> http://open.cdash.org/testDetails.php?test=190556209&build=2907224
>>
>> The issue was resolved after I reverted the add-EXPORT_NAME topic.
>>
>> I've re-added part of that topic without the failure returning. I don't
>> see how the rest of the topic could cause such failures either. I've
>> pushed it to add-EXPORT_NAME-property in my clone.
>
> After local testing of commit 1cda7beb, this hunk is the problem:
>
Thanks for trying. I couldn't reproduce it when I tried before, but I tried
again and was able to.
Actually the problem was that in the unit test the LINK_INTERFACE_LIBRARIES
property was being set already, and I added a call to
tll( ... LINK_PUBLIC ...)
which, added an entry to the LINK_INTERFACE_LIBRARIES_<CONFIG>, therefore
hiding the result of the set_property call. The fix is to convert the
set_property to a tll call too, so that the _<CONFIG> variant is also set.
It's one more reason to deprecate LINK_INTERFACE_LIBRARIES(_<CONFIG>)? and
introduce INTERFACE_LINK_LIBRARIES.
Thanks,
Steve.
More information about the cmake-developers
mailing list