[cmake-developers] ExportImport test failures

Brad King brad.king at kitware.com
Fri May 17 13:04:00 EDT 2013


On 05/17/2013 11:43 AM, Stephen Kelly wrote:
> Yesterday in the continuous dashboards, several windows machines started 
> failing with this test in a way that does not make sense:
> 
>  http://open.cdash.org/testDetails.php?test=190556209&build=2907224
> 
> The issue was resolved after I reverted the add-EXPORT_NAME topic.
> 
> I've re-added part of that topic without the failure returning. I don't see 
> how the rest of the topic could cause such failures either. I've pushed it 
> to add-EXPORT_NAME-property in my clone.

After local testing of commit 1cda7beb, this hunk is the problem:

@@ -407,7 +407,7 @@ cmExportFileGenerator::AddTargetNamespace(std::string &input,
     }
   if(this->ExportedTargets.find(tgt) != this->ExportedTargets.end())
     {
-    input = this->Namespace + input;
+    input = this->Namespace + tgt->GetExportName();
     }
   else
     {

The input is not the target name through all call paths.  I think
the call from cmExportFileGenerator::SetImportLinkProperty is the
problem.

-Brad



More information about the cmake-developers mailing list