[cmake-developers] Review request: qt4-macros-TARGET-arg

Stephen Kelly steveire at gmail.com
Mon Jun 3 12:33:07 EDT 2013


Clinton Stimpson wrote:

> On Monday, June 03, 2013 10:09:41 AM Stephen Kelly wrote:
>> Hi,
>> 
>> I've pushed a qt4-macros-TARGET-arg branch to next. It refactors the Qt 4
>> moc related macros to process a TARGET argument. The target is used as
>> the source of include directories, which are then passed to moc as -I
>> arguments.
>> 
>> Previously, those macros read the INCLUDE_DIRECTORIES directory property,
>> which is populated by the include_directories() command. So, this patch
>> to the macros makes it possible to not require the use of
>> include_directories() anymore to use the macros.
>> 
>> Clinton, could you take a look before I merge to next please?
>> 
> 
> Looks good to me.
> 

Thanks, I've merged it to next now.

Steve.





More information about the cmake-developers mailing list