[cmake-developers] Please review CXXFeatures.cmake

[Rolf Eike Beer]

Alexander Neundorf wrote:
> On Monday 29 April 2013, Rolf Eike Beer wrote:
> > Alexander Neundorf wrote:
> > > On Sunday 28 April 2013, Rolf Eike Beer wrote:
> > > > One question I see increasingly often is "how do I test for C++11
> > > > support" or for specific parts of that. For 2.8.12 I plan to include
> > > > the check module I wrote for that a while back, and that I have
> > > > reworked in the last weeks. You can find the current state in the
> > > > "rework" branch of this repository:
> > > > 
> > > > git://anongit.kde.org/scratch/dakon/cmake-cxx11
> > > 
> > > Is the try_run() in all cases necessary ?
> > > It would be better if a try_compile() would suffice, that's faster and
> > > then it works the same way when cross-compiling and when not.
> > 
> > I'm not sure about this, but the other ones I consider real bugs. Thanks
> > for catching them, will fix soon.
> 
> is this in master in the meantime ?
> I can't find it, or has it been renamed ?

Ok, I've pushed an updated version to the rework branch. A test for the 
component check is missing, but all of your other suggestions should have been 
addressed.

Has anyone anything else, otherwise I will o and put this into CMake next once 
I have the test.

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20130719/dad227a5/attachment.sig>