[cmake-developers] Review Request: Topic ExternalProject-independent-step-targets
Brad King
brad.king at kitware.com
Fri Dec 6 16:01:05 EST 2013
On 12/06/2013 01:32 PM, Brad King wrote:
> The RunCMake.ExternalProject test failed almost everywhere last
> night and still fails on every continuous. Please take a look.
Thanks for that fix. In order to untangle the topic from the
conflict with CMakeParseArguments_EmptyArgs I reverted both
topics and rebuilt ExternalProject-independent-step-targets
on master. I squashed in all the dashboard fixups except one.
The topic is currently:
ExternalProject: Add independent step targets
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e324c587
ExternalProject: Fix tests with ninja
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=fc748185
I left the ninja fix separate because it is related to this
review comment I made yesterday:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8680/focus=8855
Please look at changing the test to avoid having to update
all the existing cases as discussed in that message.
Thanks,
-Brad
More information about the cmake-developers
mailing list