[cmake-developers] [CMake] 2.8.11-rc3 generator expression error

[Stephen Kelly]

Brad King wrote:

> On 04/30/2013 04:55 AM, Stephen Kelly wrote:
>> Brad King wrote:
>>> Okay, that looks good.  Please rebase on the partial fix I merged last
>>> week so we can test it in 'next'.  I'll squash all that together later.
>> 
>> Ok, done.
> 
> Reading the commit messages and code in more detail, it looks wrong
> to have CachedLinkInterfaceIncludeDirectoriesEntries not per-config.
> It looks like the generated value can be different per-config and
> currently it accumulates cached values across multiple configs.

Yes, that's probably a more-accurate description.

> 
> CachedLinkInterfaceCompileDefinitions is per-config already.
> 
>> I think that would be more complex than just fixing the issue. I've
>> pushed an additional patch to fix it, but haven't merged it to next.
> 
> Let's rebase that on the final version of the above fixes.

Ah, I think I misread this. I just merged the commit to next anyway, so any 
rebase will include that commit anyway (I'm not sure what rebase you have in 
mind).

Thanks,

Steve.