[cmake-developers] [CMake] 2.8.11-rc3 generator expression error

Stephen Kelly steveire at gmail.com
Tue Apr 30 04:55:23 EDT 2013


Brad King wrote:

> On 04/29/2013 06:29 AM, Stephen Kelly wrote:
>> I've force-pushed the fix-multi-config-tll-include-dirs branch with a
>> more- simple fix for this issue to my clone.
> 
> Okay, that looks good.  Please rebase on the partial fix I merged last
> week so we can test it in 'next'.  I'll squash all that together later.

Ok, done.

> 
> Also I realized my local topic using GetLinkInformation is wrong because
> it includes usage requirements from everything linked, not just from
> the link *interface* closure.  I'll drop that one in favor of yours.
> 
> While working through all of the above I realized that AppendTllIncludes
> and LinkInterfaceIncludeDirectoriesEntries are not safe.  Users can
> re-write the LINK_LIBRARIES property and those other structures will
> not be updated.  IIUC they only exist to provide a backtrace for
> include directory entries.  Please drop them for now at the expense of
> the backtraces which can be restored later by tracking the backtraces
> of all tll() link information (similar to tid() now).
> 

I think that would be more complex than just fixing the issue. I've pushed 
an additional patch to fix it, but haven't merged it to next.

Thanks,

Steve.






More information about the cmake-developers mailing list