[cmake-developers] [CMake 0013651]: FindSDL.cmake is broken

Mantis Bug Tracker mantis at public.kitware.com
Sun Nov 4 09:30:05 EST 2012


The following issue has been SUBMITTED. 
====================================================================== 
http://public.kitware.com/Bug/view.php?id=13651 
====================================================================== 
Reported By:                Gino van den Bergen
Assigned To:                
====================================================================== 
Project:                    CMake
Issue ID:                   13651
Category:                   CMake
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
====================================================================== 
Date Submitted:             2012-11-04 09:30 EST
Last Modified:              2012-11-04 09:30 EST
====================================================================== 
Summary:                    FindSDL.cmake is broken
Description: 
After adding a Copyright to his name, Mr. Benjamin Eikel (what's in a name)
decided to remove a number of path suffixes that plainly broke the FindSDL.cmake
to be used in combination with the environment variable SDLDIR. This change was
unnecessary as the FindSDL.cmake script works fine for the different platforms.
I am puzzled by this action since it simply does not fix anything. I've attached
a patch that would fix this for me but clearly the best thing to do would be
revert the FindSDL*.cmake scripts back to 2.8.9 before Mr. Benjamin Eikel
started his actions.

Steps to Reproduce: 
Set environment variable pointing to your SDL installation, that would typically
look like

<SDLDIR>/bin
<SDLDIR>/include/SDL
<SDLDIR>/lib

Try to find the SDL headers and libraries with cmake 2.8.10 and see the latest
script fail.

Additional Information: 
Could someone please take some action against maintainers adding a Copyright
notice to the Find scripts, as Mr. Benjamin Eikel did? This behavior is quite
obnoxious but also puts users in a difficult position since their rights become
unclear. I do not oppose against people getting credited for their contributions
but taking a Copyright over a few modified lines of script is simply not helping
the product.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2012-11-04 09:30 Gino van den BergenNew Issue                                   

2012-11-04 09:30 Gino van den BergenFile Added: FindSDL.patch                   

======================================================================




More information about the cmake-developers mailing list