[cmake-developers] Review request: Ninja-EXPORT_COMPILE_COMMANDS

[Peter Kuemmel]

> 
> Oops. Please remove that branch from stage. I was keeping it off there to 
> get some initial feedback first. I can push it to stage later (I can
> commit to cmake too :) ).

OK deleted.

> 
> I've force pushed the branch to my own repo again.
> 
> In particular I was wondering about the first patch 'Make the Ninja 
> generator generate includes with full paths'.

This was because of a unit test on Windows.
But as Peter C. said the wrong way.

I wonder if anybody care about ninja on Windows? It's useless without
the dependency tracking.

> Is there a reason it hasn't 
> used the full path up to now? A reason not to change it like this? 
> 
> > 
> > But when I run the unit test under linux,
> > 'ctest -R CompileCommandOutput' it fails.
> > 
> > Should it work with most recent ninja?
> 
> It was generating invalid JSON before, but I've fixed that now.
> 
> Thanks,
> 
> Steve.
> 
-- 
Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de