[cmake-developers] Review request: Ninja-EXPORT_COMPILE_COMMANDS

[Stephen Kelly]

Peter Kuemmel wrote:

> 
>> 
>> Hi,
>> 
>> I've pushed a new branch to my clone for review to make the
>> CMAKE_EXPORT_COMPILE_COMMANDS option work with the Ninja generator.
>> 
>> https://gitorious.org/~steveire/cmake/steveires-cmake
>> 
>> Thanks,
>> 
>> Steve.
> 
> I've rebased 'Ninja-EXPORT_COMPILE_COMMANDS' on origin/master
> and pushed the branch to stage:
> http://cmake.org/gitweb?p=stage/cmake.git;a=shortlog;h=refs/heads/Ninja-
EXPORT_COMPILE_COMMANDS

Oops. Please remove that branch from stage. I was keeping it off there to 
get some initial feedback first. I can push it to stage later (I can commit 
to cmake too :) ).

I've force pushed the branch to my own repo again.

In particular I was wondering about the first patch 'Make the Ninja 
generator generate includes with full paths'. Is there a reason it hasn't 
used the full path up to now? A reason not to change it like this? 

> 
> But when I run the unit test under linux,
> 'ctest -R CompileCommandOutput' it fails.
> 
> Should it work with most recent ninja?

It was generating invalid JSON before, but I've fixed that now.

Thanks,

Steve.