[cmake-developers] -GNinja on Windows

[Peter Kümmel]

On 12.06.2012 19:59, Bill Hoffman wrote:
> On 6/12/2012 1:44 PM, Peter Kümmel wrote:
>>
>> I found a much simpler patch:
>>
>> https://github.com/syntheticpp/ninja/commit/0ea34053a4692f190b8c13ce0ff032a57cece047
>>
>>
>> Could you please have a look at it before I create a merge request?
>
> I would change RemoveQuotes to only remove them if they are at the start
> and end of the string.
>
> Something like this:
>
> if(str.size() == 0)
>     return str;
> if (str[0] == '\"'&&  str[str.size()-1] == '\"')
>     {
>     cleaned = str.substr(1, str.size()-2);
>     return cleaned;
>     }
> return str;
>

OK, but we need to handle strings like this:

"... \outlib.dir\outlib.c.obj".d

Peter